Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 15, 2018

@lcawl lcawl added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.4.0 v6.3.1 labels Jun 15, 2018
@lcawl lcawl requested a review from jimczi June 15, 2018 20:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jpountz
Copy link
Contributor

jpountz commented Jun 18, 2018

Documentation about this breaking change shouldn't be backported since it only breaks in 7.0.

@jpountz
Copy link
Contributor

jpountz commented Jun 18, 2018

From a release notes perspective, maybe we could manually rephrase the release note on 6.3/6.x to remove the breaking label and say that search bodies with trailing tokens will trigger deprecation warnings rather than fail.

@lcawl lcawl force-pushed the lcawley-backport-breaking-change branch from 59686e9 to d0e673f Compare June 18, 2018 17:04
@lcawl
Copy link
Contributor Author

lcawl commented Jun 18, 2018

Thanks @jpountz I moved the release notes item from the "Breaking Changes" section to the "Deprecations" section. If it would be a better fit in "Enhancements" or "Bug Fixes", let me know!

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lcawl !

@lcawl lcawl merged commit 562a43c into elastic:6.x Jun 18, 2018
@lcawl lcawl deleted the lcawley-backport-breaking-change branch June 18, 2018 17:43
dnhatn added a commit that referenced this pull request Jun 19, 2018
* 6.x:
  Add get stored script and delete stored script to high level REST API
  Increasing skip version for failing test on 6.x
  Skip get_alias tests for 5.x (#31397)
  Fix defaults in GeoShapeFieldMapper output (#31302)
  Test: better error message on failure
  Mute DefaultShardsIT#testDefaultShards test
  Fix reference to XContentBuilder.string() (#31337)
  [DOCS] Adds monitoring breaking change (#31369)
  [DOCS] Adds security breaking change (#31375)
  [DOCS] Backports breaking change (#31373)
  RestAPI: Reject forcemerge requests with a body (#30792)
  Docs: Use the default distribution to test docs (#31251)
  Use system context for cluster state update tasks (#31241)
  [DOCS] Adds testing for security APIs (#31345)
  [DOCS] Removes ML item from release highlights
  [DOCS] Removes breaking change (#31376)
  REST high-level client: add validate query API (#31077)
  Move language analyzers from server to analysis-common module. (#31300)
  Expose lucene's RemoveDuplicatesTokenFilter (#31275)
  [Test] Fix :example-plugins:rest-handler on Windows
  Delete typos in SAML docs (#31199)
  Ensure we don't use a remote profile if cluster name matches (#31331)
  Test: Skip alias tests that failed all weekend
  [DOCS] Fix version in SQL JDBC Maven template
  [DOCS] Improve install and setup section for SQL JDBC
  Add ingest-attachment support for per document `indexed_chars` limit (#31352)
  SQL: Fix rest endpoint names in node stats (#31371)
  [DOCS] Fixes small issue in release notes
  Support for remote path in reindex api Closes #22913
  [ML] Put ML filter API response should contain the filter (#31362)
  Remove trial status info from start trial doc (#31365)
  [DOCS] Added links in breaking changes pages
  [DOCS] Adds links to release notes and highlights
  Docs: Document changes in rest client
  QA: Fix tribe tests to use node selector
  REST Client: NodeSelector for node attributes (#31296)
  LLClient: Fix assertion on windows
  LLClient: Support host selection (#30523)
  Add QA project and fixture based test for discovery-ec2 plugin (#31107)
  [ML] Hold ML filter items in sorted set (#31338)
  [ML] Add description to ML filters (#31330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.3.1 v6.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants