Replace exact numDocs by soft-del count in SegmentCommitInfo #31086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b12c2f6.
dnhatn
added
>feature
:Distributed Indexing/Store
Collaborator
|
Pinging @elastic/es-distributed |
dnhatn
changed the title
Member
Author
|
run sample packaging tests |
Contributor
|
@elasticmachine run sample packaging tests |
s1monw
approved these changes
Jun 5, 2018
Contributor
s1monw
left a comment
s1monw
left a comment
There was a problem hiding this comment.
LGTM I am glad we dont' have to jump through hoops anymore for the doc stats.
| import static org.hamcrest.Matchers.containsString; | ||
| import static org.hamcrest.Matchers.notNullValue; | ||
|
|
||
| @LuceneTestCase.AwaitsFix(bugUrl = "should-be-fixed-by-upstream") |
Contributor
There was a problem hiding this comment.
can you elaborate what caused this?
Member
Author
There was a problem hiding this comment.
These tests are failing on the master branch.
This snapshot includes: - LUCENE-8341: Record soft deletes in SegmentCommitInfo which will resolve elastic#30851 - LUCENE-8335: Enforce soft-deletes field up-front
Member
Author
dnhatn
added a commit
that referenced
this pull request
Jun 5, 2018
This PR adapts/utilizes recent enhancements in Lucene-7.4: - Replaces exactNumDocs by the soft-deletes count in SegmentCommitInfo. This enhancement allows us to back out changes introduced in #30228. - Always configure the soft-deletes field in IWC
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 5, 2018
* ccr: [DOCS] Creates rest-api folder in docs [Rollup] Disallow index patterns that match the rollup index (elastic#30491) Replace exact numDocs by soft-del count in SegmentInfo (elastic#31086) Upgrade to Lucene-7.4.0-snapshot-0a7c3f462f (elastic#31073) Add cors support to NioHttpServerTransport (elastic#30827) [DOCS] Fixes security example (elastic#31082) Allow terms query in _rollup_search (elastic#30973) Removing erroneous repeat Adapt bwc versions after backporting elastic#30983 to 6.4 [Tests] Muting RatedRequestsTests#testXContentParsingIsNotLenient TEST: Retry synced-flush if ongoing ops on primary (elastic#30978) Fix docs build. Only auto-update license signature if all nodes ready (elastic#30859) Add BlobContainer.writeBlobAtomic() (elastic#30902) Add a doc value format to binary fields. (elastic#30860)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 5, 2018
* ccr: [DOCS] Creates rest-api folder in docs [Rollup] Disallow index patterns that match the rollup index (elastic#30491) Replace exact numDocs by soft-del count in SegmentInfo (elastic#31086) Upgrade to Lucene-7.4.0-snapshot-0a7c3f462f (elastic#31073) Add cors support to NioHttpServerTransport (elastic#30827) [DOCS] Fixes security example (elastic#31082) Allow terms query in _rollup_search (elastic#30973) Removing erroneous repeat Adapt bwc versions after backporting elastic#30983 to 6.4 [Tests] Muting RatedRequestsTests#testXContentParsingIsNotLenient TEST: Retry synced-flush if ongoing ops on primary (elastic#30978) Fix docs build. Only auto-update license signature if all nodes ready (elastic#30859) Add BlobContainer.writeBlobAtomic() (elastic#30902) Add a doc value format to binary fields. (elastic#30860)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts/utilizes recent enhancements in Lucene-7.4:
Replaces exactNumDocs by the soft-deletes count in SegmentCommitInfo. This enhancement allows us to back out changes introduced in Use exact numDocs in synced-flush and metadata snapshot #30228.
Always configure the soft-deletes field in IWC