Transport client: Don't validate node in handshake (#30737) #31080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to elastic#30141. Right now in the transport client we open a temporary node connection and take the node information. This node information is used to open a permanent connection that is used for the client. However, we continue to use the configured transport address. If the configured transport address is a load balancer, you might connect to a different node for the permanent connection. This causes the handshake validation to fail. This commit removes the handshake validation for the transport client when it simple node sample mode.
Tim-Brooks
added
>bug
review
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
This is just a backport. |
martijnvg
added a commit
that referenced
this pull request
Jun 5, 2018
* es/6.x: Fix compil after backport Fix index prefixes to work with span_multi (#31066) Delete superfluous UpdateRequest test Disable MultiMatchQueryBuilderTests. Disable UpdateRequestTest#testUnknownFieldParsing. Update get.asciidoc (#31084) When the 'strict' mapping option is enabled, make sure to validate split_queries_on_whitespace. Transport client: Don't validate node in handshake (#30737) (#31080) In the internal highlighter APIs, use the field type as opposed to the mapper. (#31039) [DOCS] Removes redundant authorization pages Upgrade to Lucene-7.4.0-snapshot-0a7c3f462f (#31073)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #30141. Right now in the transport client we open a
temporary node connection and take the node information. This node
information is used to open a permanent connection that is used for the
client. However, we continue to use the configured transport address.
If the configured transport address is a load balancer, you might
connect to a different node for the permanent connection. This causes
the handshake validation to fail. This commit removes the handshake
validation for the transport client when it simple node sample mode.