Update x-pack collection timeout settings docs #31043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a setting that is not available on 6.2.3, and add a setting that is available but not documented.
Collaborator
|
Pinging @elastic/es-core-infra |
danielmitterdorfer
requested changes
Oct 5, 2018
Member
danielmitterdorfer
left a comment
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Thanks for your PR @dilchenko and sorry that this has fallen through the cracks! I left some comments. Can you please address them? Then I think we'll be good to merge it.
|
|
||
| Sets the timeout for collecting the cluster statistics. Defaults to `10s`. | ||
|
|
||
| `xpack.monitoring.collection.node.stats.timeout: 60s`:: |
Member
There was a problem hiding this comment.
Could you please just document the name of the setting here as this is more consistent with the rest of the docs?
|
|
||
| Sets the timeout for collecting index statistics. Defaults to `10s`. | ||
|
|
||
| `xpack.monitoring.collection.indices.stats.timeout`:: |
Member
There was a problem hiding this comment.
Seems this has already been removed meanwhile in #32229. Can you please merge master and resolve the conflict? Then all should be fine.
danielmitterdorfer
added a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Mar 8, 2019
With this commit we document the setting `xpack.monitoring.collection.node.stats.timeout` that has been missing so far in the docs. Supersedes elastic#31043
Member
|
Closing unmerged in favor of #39846. |
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 18, 2019
With this commit we document the setting `xpack.monitoring.collection.node.stats.timeout` that has been missing so far in the docs. Supersedes #31043
danielmitterdorfer
added a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Mar 18, 2019
With this commit we document the setting `xpack.monitoring.collection.node.stats.timeout` that has been missing so far in the docs. Supersedes elastic#31043
danielmitterdorfer
added a commit
to danielmitterdorfer/elasticsearch
that referenced
this pull request
Mar 18, 2019
With this commit we document the setting `xpack.monitoring.collection.node.stats.timeout` that has been missing so far in the docs. Supersedes elastic#31043
This was referenced Mar 18, 2019
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 18, 2019
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 18, 2019
danielmitterdorfer
added a commit
that referenced
this pull request
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a setting that is not available on 6.2.3, and add a setting that is available but not documented.