Add support for skippable named writeables #30948
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While XContent parsing allows to skip over unknown fields or subobjects, there is no such feature in the StreamInput / StreamOutput world. This PR adds support for skippable named writeables:
ClusterState.CustomandMetaData.Customas skippable.StreamOuthas a new methodwriteSkippableNamedWriteablewhich calculates the number of bytes to be written for theNamedWriteableand writes this as a header.StreamInputhas a new methodreadSkippableNamedWriteablewhich uses the header written bywriteSkippableNamedWriteableto possibly skip theNamedWriteableobject.ClusterState.CustomandMetaData.Customare now written and read using these two new methodswriteSkippableNamedWriteableandreadSkippableNamedWriteable.customsis only introduced in the transport client. This allows a transport client to deserialize a cluster state even if does not know about all thecustomsobjects.