Restrict Document list access in ParseContext #29463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we expose a mutable list of documents in ParseContext via ParseContext#docs(). This, on the one hand places knowledge how to access nested documnts in multiple places and on the other allows for potential illegal access to nested only docs after the docs are reversed. This change restricts the access and streamlines nested / non-root doc access.
s1monw
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search-aggs |
jpountz
approved these changes
Apr 11, 2018
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
I left some suggestions but it looks good overall.
| } | ||
| } | ||
|
|
||
| public abstract Iterable<Document> nonRootIterator(); |
Contributor
There was a problem hiding this comment.
I think it's confusing that the name says iterator but the return value is an iterable? Maybe nonRootDocuments?
Contributor
There was a problem hiding this comment.
Also can you add some docs?
| if (!fieldType().stored()) { | ||
| return; | ||
| } | ||
| boolean needsOriginalSource = false; |
Contributor
There was a problem hiding this comment.
this variable is never read?
Contributor
Author
There was a problem hiding this comment.
ah leftover from some prototyping.
martijnvg
approved these changes
Apr 11, 2018
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Thanks for locking this down.
jpountz
approved these changes
Apr 11, 2018
s1monw
added a commit
that referenced
this pull request
Apr 11, 2018
Today we expose a mutable list of documents in ParseContext via ParseContext#docs(). This, on the one hand places knowledge how to access nested documnts in multiple places and on the other allows for potential illegal access to nested only docs after the docs are reversed. This change restricts the access and streamlines nested / non-root doc access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we expose a mutable list of documents in ParseContext via
ParseContext#docs(). This, on the one hand places knowledge how
to access nested documnts in multiple places and on the other
allows for potential illegal access to nested only docs after
the docs are reversed. This change restricts the access and
streamlines nested / non-root doc access.