Skip to content

Version conflict exception message enhancement #29432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2018
Merged

Version conflict exception message enhancement #29432

merged 1 commit into from
Apr 10, 2018

Conversation

@vladimirdolzhenko
Copy link
Contributor

@vladimirdolzhenko vladimirdolzhenko commented Apr 9, 2018

Report doc is not found rather on PUT ?version=X rather current version [-1] is different than the one provided

Closes #21278

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

bleskes
bleskes suggested changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I left a minor ask.

server/src/main/java/org/elasticsearch/index/VersionType.java Outdated
Copy link
Contributor

@bleskes bleskes Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we say something about the version we expected to find?

server/src/main/java/org/elasticsearch/index/VersionType.java Outdated
Copy link
Contributor

@bleskes bleskes Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

server/src/main/java/org/elasticsearch/index/VersionType.java Outdated
Copy link
Contributor

@bleskes bleskes Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

server/src/main/java/org/elasticsearch/index/VersionType.java Outdated
Copy link
Contributor

@bleskes bleskes Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@vladimirdolzhenko
Version conflict exception message enhancement
a6e0e02 
Report doc is not found rather on PUT ?version=X rather current version [-1] is different than the one provided

Closes elastic#21278
@vladimirdolzhenko
Copy link
Contributor Author

vladimirdolzhenko commented Apr 10, 2018

@bleskes amendments are done

bleskes
bleskes approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirdolzhenko vladimirdolzhenko added the :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Apr 10, 2018
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 10, 2018

Pinging @elastic/es-distributed

@vladimirdolzhenko vladimirdolzhenko merged commit 03d1a7e into elastic:master Apr 10, 2018
@vladimirdolzhenko vladimirdolzhenko deleted the fix/21278 branch April 10, 2018 11:43
vladimirdolzhenko added a commit that referenced this pull request Apr 10, 2018
@vladimirdolzhenko
Version conflict exception message enhancement (#29432)
ae1a7f4 
Report doc is not found rather on PUT ?version=X rather current version [-1] is different than the one provided

Closes #21278

(cherry picked from commit 03d1a7e)
@clintongormley
Copy link
Contributor

clintongormley commented Apr 10, 2018

This is a breaking change, so I've added the breaking label

vladimirdolzhenko added a commit that referenced this pull request Apr 10, 2018
@vladimirdolzhenko
Revert "Version conflict exception message enhancement (#29432)"
8c35890 
This reverts commit ae1a7f4
@lcawl lcawl mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bleskes bleskes bleskes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>breaking :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vladimirdolzhenko @elasticmachine @clintongormley @bleskes @colings86