Use fixture to test repository-azure plugin #29347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
review
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
3 tasks
ywelsch
approved these changes
Apr 5, 2018
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
I have one ask (can be done as a follow-up). LGTM
Contributor
There was a problem hiding this comment.
can we share the code between this and the other fixtures? Maybe something to put into test:framework? There's lots of code duplication here.
Member
Author
There was a problem hiding this comment.
Yes I also thought about that. The fixtures will ve moved to a qa/third-party project in upcoming pull requests, so maybe the common code could be located there too.
This commit adds a new fixture that emulates an Azure Storage service in order to improve the existing integration tests. This is very similar to what has been made for Google Cloud Storage in elastic#28788 and for Amazon S3 in elastic#29296, and it would have helped a lot to catch bugs like elastic#22534.
tlrx
force-pushed
the
add-fixture-for-repository-azure
branch
from
548bbda to
97cb6b8
Compare
Member
Author
|
Thanks @ywelsch ! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Apr 30, 2018
Similarly to what has been done in for the repository-s3 plugin, this pull request moves the fixture test into a dedicated repository-azure/qa/microsoft-azure-storage project. It also exposes some environment variables which allows to execute the integration tests against the real Azure Storage service. When the environment variables are not defined, the integration tests are executed using the fixture added in elastic#29347. Related to elastic#29349
tlrx
added a commit
that referenced
this pull request
May 2, 2018
Similarly to what has been done in for the repository-s3 plugin, this pull request moves the fixture test into a dedicated repository-azure/qa/microsoft-azure-storage project. It also exposes some environment variables which allows to execute the integration tests against the real Azure Storage service. When the environment variables are not defined, the integration tests are executed using the fixture added in #29347. Closes #29349
tlrx
added a commit
that referenced
this pull request
May 2, 2018
Similarly to what has been done in for the repository-s3 plugin, this pull request moves the fixture test into a dedicated repository-azure/qa/microsoft-azure-storage project. It also exposes some environment variables which allows to execute the integration tests against the real Azure Storage service. When the environment variables are not defined, the integration tests are executed using the fixture added in #29347. Closes #29349
Member
Author
|
This change was backported to 6.x together with #30253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new fixture that emulates an Azure Storage service in order to improve the existing integration tests. This is very similar to what has been made for Google Cloud Storage in #28788 and for Amazon S3 in #29296, and it would have helped a lot to catch bugs like #22534.
It also adds more unit tests in a new
AzureBlobStoreTestsclass.