Propagate mapping.single_type setting on shrinked index #29202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index.mapping.single_type setting is not propagated when shrinking an index created in 5.x. This breaks search/get on the shrinked index because this setting is used to choose whether `_uid` or `_id` field should be used as the primary key. This commit fixes this bug by copying the setting in the shrinked index.
jimczi
added
>bug
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-infra |
bleskes
approved these changes
Mar 22, 2018
Contributor
bleskes
left a comment
bleskes
left a comment
There was a problem hiding this comment.
LGTM. I wonder if we have a qa test for this. I would prefer a real 5.6 index as an input.
Contributor
I missed that this is exactly what you did. All good and sorry for the noise. |
martijnvg
added a commit
that referenced
this pull request
Mar 26, 2018
* es/6.x: (29 commits) [Docs] Add rank_eval size parameter k (#29218) Docs: Update docs/index_.asciidoc (#29172) Docs: Link C++ client lib elasticlient (#28949) Docs: HighLevelRestClient#multiSearch (#29144) [DOCS] Remove ignore_z_value parameter link Add Z value support to geo_shape Change BroadcastResponse from ToXContentFragment to ToXContentObject (#28878) REST : Split `RestUpgradeAction` into two actions (#29124) [DOCS] Unregister repository instead of deleting it (#29206) Remove type casts in logging in server component (#28807) Add error file docs to important settings Add note to low-level client docs for DNS caching (#29213) testShrinkAfterUpgrade should only set mapping.single_type if bwc version > 5.5.0 Harden periodically check to avoid endless flush loop (#29125) REST high-level client: add force merge API (#28896) Remove license information from README.textile (#29198) Decouple more classes from XContentBuilder and make builder strict (#29197) Propagate mapping.single_type setting on shrinked index (#29202) [Docs] Fix missing closing block in cluster/misc.asciidoc RankEvalRequest should implement IndicesRequest (#29188) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index.mapping.single_type setting is not propagated when shrinking an index created in 5.x.
This breaks search/get on the shrinked index because this setting is used to choose
whether
_uidor_idfield should be used as the primary key.This commit fixes this bug by copying the setting in the shrinked index.