Tests - fix incorrect agg test assumption that zero-doc buckets will be returned #29167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturned by the adjacency matrix aggregation
cbuescher
added
>test
Collaborator
|
Pinging @elastic/es-search-aggs |
cbuescher
approved these changes
Mar 21, 2018
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, I assume this should also be backported to most of the 6.x branches, maybe 5.6 (don't know when this aggregation was introduced tbh). Can you add the appropriate labels when/if you backport please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adjacency matrix aggregation does not return buckets with zero doc counts as it can be a very sparse result set. Changed construction of test's expected results.
Closes #29159