Fix #29057 CWD to ES_HOME does not change drive #29086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /d switch on cd also changes the current drive in DOS. This allows the bat file to be called while the users CWD is on a different drive.
Member
|
LGTM. Please change the commit summary to something more meaningful, eg "Ensure changing dir to ES_HOME works across drives" and move the "fixes #29057" to the description. |
jasontedor
added
the
:Delivery/Packaging
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
@rjernst mind changing the commit message when hitting |
Member
|
That leaves open the possibility that this change is untested. Have you tested this change? |
Member
Author
|
Yes, I did in a VM which has two drives attached. |
jasontedor
pushed a commit
that referenced
this pull request
Mar 16, 2018
The cd command on Windows has an oddity regarding changing directories. If the drive of the current directory is a different drive than than of the directory that was passed to the cd command, cd acts in query mode and does not change the current directory. Instead, a flag is needed to put the cd command into set mode so that the directory actually changes. This causes a problem when starting Elasticsearch from a directory different than the one where it is installed and this commit fixes the issue.
martijnvg
added a commit
that referenced
this pull request
Mar 16, 2018
* es/6.x: (89 commits) Clarify requirements of strict date formats. (#29090) Clarify that dates are always rendered as strings. (#29093) [Docs] Fix link to Grok patterns (#29088) Fix starting on Windows from another drive (#29086) Use removeTask instead of finishTask in PersistentTasksClusterService (#29055) Added minimal docs for reindex api in java-api docs Allow overriding JVM options in Windows service (#29044) Clarify how to set compiler and runtime JDKs (#29101) Fix Parsing Bug with Update By Query for Stored Scripts (#29039) TEST: write ops should execute under shard permit (#28966) [DOCS] Add X-Pack upgrade details (#29038) Revert "Improve error message for installing plugin (#28298)" Docs: HighLevelRestClient#exists (#29073) Validate regular expressions in dynamic templates. (#29013) [Tests] Fix GetResultTests and DocumentFieldTests failures (#29083) Reenable LiveVersionMapTests.testRamBytesUsed on Java 9. (#29063) Mute failing GetResultTests and DocumentFieldTests [Docs] Fix Java Api index administration usage (#28260) Improve error message for installing plugin (#28298) Decouple XContentBuilder from BytesReference (#28972) ...
martijnvg
added a commit
that referenced
this pull request
Mar 16, 2018
* es/master: (97 commits) Clarify requirements of strict date formats. (#29090) Clarify that dates are always rendered as strings. (#29093) Compilation fix for #29067 [Docs] Fix link to Grok patterns (#29088) Store offsets in index prefix fields when stored in the parent field (#29067) Fix starting on Windows from another drive (#29086) Use removeTask instead of finishTask in PersistentTasksClusterService (#29055) Added minimal docs for reindex api in java-api docs Allow overriding JVM options in Windows service (#29044) Clarify how to set compiler and runtime JDKs (#29101) CLI: Close subcommands in MultiCommand (#28954) TEST: write ops should execute under shard permit (#28966) [DOCS] Add X-Pack upgrade details (#29038) Revert "Improve error message for installing plugin (#28298)" Docs: HighLevelRestClient#exists (#29073) Validate regular expressions in dynamic templates. (#29013) [Tests] Fix GetResultTests and DocumentFieldTests failures (#29083) Reenable LiveVersionMapTests.testRamBytesUsed on Java 9. (#29063) Mute failing GetResultTests and DocumentFieldTests Improve error message for installing plugin (#28298) ...
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 30, 2018
This commit patches the elasticsearch.bat file for 6.2 versions to include the fix in PR elastic/elasticsearch#29086
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 30, 2018
This commit patches the elasticsearch.bat file for 6.2 versions to include the fix in PR elastic/elasticsearch#29086
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 30, 2018
This commit patches the elasticsearch.bat file for 6.2 versions to include the fix in PR elastic/elasticsearch#29086 (cherry picked from commit 41c586f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /d switch on cd also changes the current drive in DOS.
This allows the bat file to be called while the users CWD is on a different drive.