Docs: HighLevelRestClient#ping #29070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for `HighLevelRestClient#ping`. Relates to elastic#28389
Collaborator
|
Pinging @elastic/es-core-infra |
nik9000
commented
Mar 14, 2018
| * // tag::example[] | ||
| * // end::example[] | ||
| * | ||
| * Where example is your tag name. |
Member
Author
There was a problem hiding this comment.
I don't think we need these comments any more. They were useful when I first built the extraction tool for education but I think something like what I have now is shorter and easier to read. Ideas? Suggestions?
| * Code wrapped in {@code tag} and {@code end} tags is included in the docs. | ||
| */ | ||
| public class MainDocumentationIT extends ESRestHighLevelClientTestCase { | ||
| public class MiscellaneousDocumentationIT extends ESRestHighLevelClientTestCase { |
Member
Author
There was a problem hiding this comment.
I renamed this because I'd like to stick the other miscellaneous methods into this test.
4 tasks
nik9000
added a commit
that referenced
this pull request
Mar 14, 2018
Add documentation for `HighLevelRestClient#ping`. Relates to #28389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for
HighLevelRestClient#ping.Relates to #28389