Disallow logger methods with Object parameter #28969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>enhancement
:Core/Infra/Logging
Collaborator
|
Pinging @elastic/es-core-infra |
nik9000
approved these changes
Mar 9, 2018
jasontedor
approved these changes
Mar 9, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. Thanks @ywelsch, good change.
ywelsch
added a commit
that referenced
this pull request
Mar 12, 2018
Log4j2 provides a wide range of logging methods. Our code typically only uses a subset of them. In particular, uses of the methods trace|debug|info|warn|error|fatal(Object) or trace|debug|info|warn|error|fatal(Object, Throwable) have all been wrong, leading to not properly logging the provided message. To prevent these issues in the future, the corresponding Logger methods have been blacklisted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log4j2 provides a wide range of logging methods. Our code typically only uses a subset of them. In particular, uses of the methods
trace|debug|info|warn|error|fatal(Object)ortrace|debug|info|warn|error|fatal(Object, Throwable)have all been wrong, leading to not properly logging the provided message. To prevent these issues in the future, I propose blacklisting these two methods.