fix query string syntax doc when OR operator is missed #28882
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
I left some comments, I think we should just remove the sentence that you changed.
|
|
||
| * where the `title` field contains `quick` or `brown`. | ||
| If you omit the OR operator the default operator will be used | ||
| If you omit the OR operator, the default operator will be used (except if `title` field is typed `keyword`) |
There was a problem hiding this comment.
I think we should remove this sentence completely. We don't split on whitespace anymore so we shouldn't assume that quick and brown are going to be separated. It depends only on the tokenizer that is use for the field. We've added a warning section at the beginning of the docs regarding keyword field so I think it's enough.
| `quick` or `brown` (note how we need to escape the `*` with a backslash): | ||
|
|
||
| book.\*:(quick brown) | ||
| book.\*:(quick OR brown) |
|
@jimczi |
|
@jimczi |
|
Hi @jimczi |
|
Thanks @jimczi for the merge ! |
* master: (80 commits) Remove HTTP max content length leniency (elastic#29337) Begin moving XContent to a separate lib/artifact (elastic#29300) Java versions for ci (elastic#29320) Minor cleanup in the InternalEngine (elastic#29241) Clarify expectations of false positives/negatives (elastic#27964) Update docs on vertex ordering (elastic#27963) Revert "REST high-level client: add support for Indices Update Settings API (elastic#28892)" (elastic#29323) [test] remove Streamable serde assertions (elastic#29307) Improve query string docs (elastic#28882) fix query string example for boolean query (elastic#28881) Resolve unchecked cast warnings introduced with elastic#28892 REST high-level client: add support for Indices Update Settings API (elastic#28892) Search: Validate script query is run with a single script (elastic#29304) [DOCS] Added info on WGS-84. Closes issue elastic#3590 (elastic#29305) Increase timeout on Netty client latch for tests Build: Use branch specific refspec sysprop for bwc builds (elastic#29299) TEST: trim unsafe commits before opening engine Move trimming unsafe commits from engine ctor to store (elastic#29260) Fix incorrect geohash for lat 90, lon 180 (elastic#29256) Do not load global state when deleting a snapshot (elastic#29278) ...
4 participants
@jimczi
I complete here your PR #28798 to fix issue #28719