Fix build.snapshot bug in version collection #28641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build.snapshot was mistakenly passed in to every snapshot version, so when release tests were run, these versions were mistaken as released entities and could not be found in maven, because they do not exist. This fix removes that bug in logic, and always makes them proper snapshots. This has a benefit of cleaning up the VersionUtilsTests because they no longer rely on different sets of versions to check against, which was also a bug.
Contributor
Author
|
@rjernst I noticed the actual/expected are opposite of what they were a few months ago. Should I change that back as well? it seems like this is backwards as i read it today. -- Nope, Im wrong. Its using assertThat, so its proper |
hub-cap
added a commit
that referenced
this pull request
Feb 12, 2018
The build.snapshot was mistakenly passed in to every snapshot version, so when release tests were run, these versions were mistaken as released entities and could not be found in maven, because they do not exist. This fix removes that bug in logic, and always makes them proper snapshots. This has a benefit of cleaning up the VersionUtilsTests because they no longer rely on different sets of versions to check against, which was also a bug.
hub-cap
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Feb 13, 2018
The build.snapshot flag used by the main build was being propagated down into the bwc snapshot builds, which is not correct. The bwc subprojects are always meant to be snapshot builds, or null if they do not exist. Marking these builds as non snapshots threw the release off as it was looking for -SNAPSHOT builds. Relates elastic#28641
hub-cap
added a commit
that referenced
this pull request
Feb 13, 2018
The build.snapshot flag used by the main build was being propagated down into the bwc snapshot builds, which is not correct. The bwc subprojects are always meant to be snapshot builds, or null if they do not exist. Marking these builds as non snapshots threw the release off as it was looking for -SNAPSHOT builds. Relates #28641
hub-cap
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Feb 13, 2018
The build.snapshot flag used by the main build was being propagated down into the bwc snapshot builds, which is not correct. The bwc subprojects are always meant to be snapshot builds, or null if they do not exist. Marking these builds as non snapshots threw the release off as it was looking for -SNAPSHOT builds. Relates elastic#28641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build.snapshot was mistakenly passed in to every snapshot version,
so when release tests were run, these versions were mistaken as released
entities and could not be found in maven, because they do not
exist. This fix removes that bug in logic, and always makes them proper
snapshots. This has a benefit of cleaning up the VersionUtilsTests
because they no longer rely on different sets of versions to check
against, which was also a bug.