Skip to content

Build: Improve test status logging #28563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2018
Merged

Build: Improve test status logging #28563

merged 1 commit into from
Feb 9, 2018

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Feb 8, 2018

Tests use the (internal) gradle progress logger. Since aroudn gradle
4.0, loggers can have children loggers which each get their own line of
updating output. This commit improves the test status output to give
each jvm its own status line, as well as lines for suite and test
counts. It also fixes an issue where the progress logger was not marked
as completed, which caused its last output to never be cleared.

@rjernst
Build: Improve test status logging
bba7e4a 
Tests use the (internal) gradle progress logger. Since aroudn gradle
4.0, loggers can have children loggers which each get their own line of
updating output. This commit improves the test status output to give
each jvm its own status line, as well as lines for suite and test
counts. It also fixes an issue where the progress logger was not marked
as completed, which caused its last output to never be cleared.
@rjernst rjernst added :Delivery/Build Build or test infrastructure v7.0.0 v6.3.0 labels Feb 8, 2018
@rjernst
Copy link
Member Author

rjernst commented Feb 8, 2018

The output looks something like this:

<============-> 97% EXECUTING [1m 50s]
> :server:test > Suites: 555/1043
> :server:test > Tests: completed: 3600, failed: 0, ignored: 38
> :server:test > J0: IndexLevelReplicationTests.testSimpleAppendOnlyReplication completed [0.55s]
> :server:test > J1: BytesRefHashTests.testSize completed [0.29s]
> :server:test > J2: FuzzyQueryBuilderTests.testQueryWrappedInArray completed [0.00s]
> :server:test > J3: CombinedDeletionPolicyTests - initializing

I'm happy to change this if anyone has a better ideas for how to structure the data.

@rjernst rjernst requested a review from nik9000 February 8, 2018 08:17
nik9000
nik9000 approved these changes Feb 9, 2018
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@rjernst rjernst merged commit b637a5b into elastic:master Feb 9, 2018
@rjernst rjernst deleted the gradle_test_logging branch February 9, 2018 19:29
rjernst added a commit that referenced this pull request Feb 9, 2018
@rjernst
Build: Improve test status logging (#28563)
862e841 
Tests use the (internal) gradle progress logger. Since aroudn gradle
4.0, loggers can have children loggers which each get their own line of
updating output. This commit improves the test status output to give
each jvm its own status line, as well as lines for suite and test
counts. It also fixes an issue where the progress logger was not marked
as completed, which caused its last output to never be cleared.
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 12, 2019
@matriv
Build: Fix issue with test status logging
ebd058b 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
@matriv matriv mentioned this pull request Feb 12, 2019
Merged
matriv added a commit that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (#38799)
f8d86f9 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: #28563
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (elastic#38799)
d7165a8 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
@matriv matriv mentioned this pull request Feb 15, 2019
Merged
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (elastic#38799)
a16de4a 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
This was referenced Feb 15, 2019
Merged
Merged
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (elastic#38799)
adef40c 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
@matriv matriv mentioned this pull request Feb 15, 2019
Merged
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (elastic#38799)
ba81cd3 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
@matriv matriv mentioned this pull request Feb 15, 2019
Merged
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (elastic#38799)
f745406 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
@matriv matriv mentioned this pull request Feb 15, 2019
Closed
matriv added a commit that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (#38799) (#38943)
6181d2f 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: #28563
Backport: #38799
matriv added a commit to matriv/elasticsearch that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (elastic#38799)
a2f334f 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: elastic#28563
matriv added a commit that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (#38799) (#38945)
a3e9f4b 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: #28563
matriv added a commit that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (#38799) (#38950)
ea231ba 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: #28563
Backport: #38799
matriv added a commit that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (#38799) (#38951)
22ccd7a 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: #28563
Backport: #38799
matriv added a commit that referenced this pull request Feb 15, 2019
@matriv
Build: Fix issue with test status logging (#38799) (#38953)
157173d 
Handle the case of `Description` being null which is a valid case as
described in the `HeartBeatEvent`'s javadoc, which previously resulted
in exceptions that "pollute" the build output.

Follows: #28563
Backport: #38799
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.3.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rjernst @nik9000 @colings86 @mark-vieira