Skip to content

Conversation

@Cladis
Copy link
Contributor

@Cladis Cladis commented Feb 7, 2018

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cladis thanks a lot for your help in improving our docs, looks good to me.
This has already been corrected in 5.5 and any newer version, we typically don't correct all documentation typos in older versions than the last minor of the last major (that would be 5.6 in this case), but since this is a small change I will merge it. Please try to open similar documentation type changes either to master or the current version if possible in the future, if applicable we will backport them to all the currently "active" minor versions.

@cbuescher
Copy link
Member

@Cladis also, in order to get this merged, I'd ask you to sign the CLA please.

@Cladis
Copy link
Contributor Author

Cladis commented Feb 7, 2018

@cbuescher , well, this is clearly below threshold of originality ergo a public domain change. I'll sign the CLA in a couple of hours if absolutely needed, though.

@cbuescher
Copy link
Member

@Cladis I agree on the "threshold of originality", however we have a policy here for all contributions to code as well as documentation. If you find signing the CLA for this too big a hassle we can also close this issue, the typo is corrected for all versions >5.5

@Cladis
Copy link
Contributor Author

Cladis commented Feb 8, 2018

Well, I believe I have signed it now.

@cbuescher
Copy link
Member

@Cladis thanks a lot, will merge this to the 5.x branches that still have this typo then

@cbuescher cbuescher merged commit f0fc2ef into elastic:5.0 Feb 8, 2018
@cbuescher cbuescher removed the v5.4.4 label Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants