-
Notifications
You must be signed in to change notification settings - Fork 25.6k
subsitution → substitution typo fix #28549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cbuescher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cladis thanks a lot for your help in improving our docs, looks good to me.
This has already been corrected in 5.5 and any newer version, we typically don't correct all documentation typos in older versions than the last minor of the last major (that would be 5.6 in this case), but since this is a small change I will merge it. Please try to open similar documentation type changes either to master or the current version if possible in the future, if applicable we will backport them to all the currently "active" minor versions.
|
@Cladis also, in order to get this merged, I'd ask you to sign the CLA please. |
|
@cbuescher , well, this is clearly below threshold of originality ergo a public domain change. I'll sign the CLA in a couple of hours if absolutely needed, though. |
|
@Cladis I agree on the "threshold of originality", however we have a policy here for all contributions to code as well as documentation. If you find signing the CLA for this too big a hassle we can also close this issue, the typo is corrected for all versions >5.5 |
|
Well, I believe I have signed it now. |
|
@Cladis thanks a lot, will merge this to the 5.x branches that still have this typo then |
No description provided.