Skip to content

Conversation

@iheggo
Copy link
Contributor

@iheggo iheggo commented Feb 4, 2018

The example of illustrating the idea of percentiles is incorrect, some numbers are wrong and the clarification is unclear. Though, I adjusted it slightly to make it better and easy to understand

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
You very well noticed 10-723ms and 941-980ms numbers.
But I don't think this sentence is right: "with majority of a load time between 168ms to 723ms". These numbers denote 25% and 75% percentiles, so only half of loads fall into this range. I think your previous sentence normally loads in 10-723ms should be enough.

Eliminating the false sentence about majority of load time
@iheggo
Copy link
Contributor Author

iheggo commented Feb 7, 2018

You are welcome!
Yes, you are right. Actually I meant to say an average or moderate rate.
However, I've considered your suggestion. I've removed this confusing sentence.

@mayya-sharipova mayya-sharipova merged commit ab1d6c3 into elastic:6.1 Feb 7, 2018
@mayya-sharipova
Copy link
Contributor

@iheggo Thanks, later today I will merge your changes to other branches as well.

mayya-sharipova pushed a commit that referenced this pull request Feb 9, 2018
* Correct the explanation of load time percentiles

* Adjusting the percentile clarification

Eliminating the false sentence about majority of load time
mayya-sharipova pushed a commit that referenced this pull request Feb 9, 2018
* Correct the explanation of load time percentiles

* Adjusting the percentile clarification

Eliminating the false sentence about majority of load time
mayya-sharipova pushed a commit that referenced this pull request Feb 9, 2018
* Correct the explanation of load time percentiles

* Adjusting the percentile clarification

Eliminating the false sentence about majority of load time
mayya-sharipova pushed a commit that referenced this pull request Feb 9, 2018
* Correct the explanation of load time percentiles

* Adjusting the percentile clarification

Eliminating the false sentence about majority of load time
mayya-sharipova pushed a commit that referenced this pull request Feb 9, 2018
* Correct the explanation of load time percentiles

* Adjusting the percentile clarification

Eliminating the false sentence about majority of load time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants