-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Correct the explanation of load time percentiles #28510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
mayya-sharipova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
You very well noticed 10-723ms and 941-980ms numbers.
But I don't think this sentence is right: "with majority of a load time between 168ms to 723ms". These numbers denote 25% and 75% percentiles, so only half of loads fall into this range. I think your previous sentence normally loads in 10-723ms should be enough.
Eliminating the false sentence about majority of load time
|
You are welcome! |
|
@iheggo Thanks, later today I will merge your changes to other branches as well. |
* Correct the explanation of load time percentiles * Adjusting the percentile clarification Eliminating the false sentence about majority of load time
* Correct the explanation of load time percentiles * Adjusting the percentile clarification Eliminating the false sentence about majority of load time
* Correct the explanation of load time percentiles * Adjusting the percentile clarification Eliminating the false sentence about majority of load time
* Correct the explanation of load time percentiles * Adjusting the percentile clarification Eliminating the false sentence about majority of load time
* Correct the explanation of load time percentiles * Adjusting the percentile clarification Eliminating the false sentence about majority of load time
The example of illustrating the idea of percentiles is incorrect, some numbers are wrong and the clarification is unclear. Though, I adjusted it slightly to make it better and easy to understand