Skip to content

Add missing "aggregations" word #28507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing "aggregations" word #28507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference/mapping/types/nested.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ The following parameters are accepted by `nested` fields:

Because nested documents are indexed as separate documents, they can only be
accessed within the scope of the `nested` query, the
`nested`/`reverse_nested`, or <<nested-inner-hits,nested inner hits>>.
`nested`/`reverse_nested` aggregations, or <<nested-inner-hits,nested inner hits>>.
Copy link
Member

@cbuescher cbuescher Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd prefer the singular aggregation here.

Copy link
Contributor Author

@alexmorosmarco alexmorosmarco Feb 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer it in plural to better state that those are 2 different aggregations.


For instance, if a string field within a nested document has
<<index-options,`index_options`>> set to `offsets` to allow use of the postings
Expand Down