Improve failure message when restoring an index that already exists in the cluster #28498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
approved these changes
Feb 2, 2018
Contributor
imotov
left a comment
imotov
left a comment
There was a problem hiding this comment.
LGTM, I think we could simplify it a bit:
"Either close or delete the existing index or restore the index under a different name by providing a replacement name and a rename pattern"
igor-kupczynski
approved these changes
Feb 2, 2018
Contributor
igor-kupczynski
left a comment
igor-kupczynski
left a comment
There was a problem hiding this comment.
That was fast 👍 Both the PRed version and the one suggested by @imotov LGTM
ywelsch
added a commit
that referenced
this pull request
Feb 6, 2018
…n the cluster (#28498) Makes the message more actionable and removes the focus on the fact that the index is open.
ywelsch
added a commit
that referenced
this pull request
Feb 6, 2018
…n the cluster (#28498) Makes the message more actionable and removes the focus on the fact that the index is open.
martijnvg
added a commit
that referenced
this pull request
Feb 7, 2018
* es/master: Added more parameter to PersistentTaskPlugin#getPersistentTasksExecutor(...) [Tests] Relax assertion in SuggestStatsIT (#28544) Make internal Rounding fields final (#28532) Fix the ability to remove old plugin [TEST] Expand failure message for wildfly integration tests Add 6.2.1 version constant Remove feature parsing for GetIndicesAction (#28535) No refresh on shard activation needed (#28013) Improve failure message when restoring an index that already exists in the cluster (#28498) Use right skip versions. [Docs] Fix incomplete URLs (#28528) Use non deprecated xcontenthelper (#28503) Painless: Fixes a null pointer exception in certain cases of for loop usage (#28506)
martijnvg
added a commit
that referenced
this pull request
Feb 7, 2018
* es/6.x: Added more parameter to PersistentTaskPlugin#getPersistentTasksExecutor(...) [Tests] Relax assertion in SuggestStatsIT (#28544) Make internal Rounding fields final (#28532) Skip verify versions for buggy cgroup2 handling Fix the ability to remove old plugin [TEST] Expand failure message for wildfly integration tests Add 6.2.1 version constant [DOCS] Adding 6.2 RNs [DOCS] Added entry for 6.2.0 RNs Remove feature parsing for GetIndicesAction (#28535) No refresh on shard activation needed (#28013) Improve failure message when restoring an index that already exists in the cluster (#28498) testIndexCausesIndexCreation should not use the `_primary` preference Use right skip versions. [Docs] Fix incomplete URLs (#28528) Use non deprecated xcontenthelper (#28503) Painless: Fixes a null pointer exception in certain cases of for loop usage (#28506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the message more actionable and removes the focus on the fact that the index is open.