Fixes Eclipse build after secure-sm project was added #28480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
approved these changes
Feb 1, 2018
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
Not tested but this looks good to me.
jasontedor
approved these changes
Feb 1, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
This looks identical to the NIO setup, so if that’s working I have to assume it’s alright. I do not use Eclipse though so that’s all I can do to assess this. I say push it if it fixes Eclipse for you. And sorry about it breaking.
Contributor
Author
|
@jasontedor np, Eclipse is a tricky beast to please 😄 @markharwood tested this for me so I'm going to merge and backport it |
colings86
added a commit
that referenced
this pull request
Feb 1, 2018
Contributor
Author
|
merged and backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few eclipse specific puts of the build that were forgotten when the secure-sm module was added. This change adds those missing pieces