Skip to content

Java client: Avoid throwing a TimeoutException after the operation wa… #28387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Java client: Avoid throwing a TimeoutException after the operation wa… #28387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions client/rest/src/main/java/org/elasticsearch/client/RestClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@ public final class RestClientBuilder {
public static final int DEFAULT_CONNECT_TIMEOUT_MILLIS = 1000;
public static final int DEFAULT_SOCKET_TIMEOUT_MILLIS = 30000;
public static final int DEFAULT_MAX_RETRY_TIMEOUT_MILLIS = DEFAULT_SOCKET_TIMEOUT_MILLIS;
public static final int DEFAULT_CONNECTION_REQUEST_TIMEOUT_MILLIS = 500;

/**
* Disabled as Apache Http Async Client would otherwise throw TimeoutException(s) even when returning connections to
* the pool, after having done performed an RPC successfully.
* See also https://github.com/elastic/elasticsearch/issues/24069
*/
public static final int DEFAULT_CONNECTION_REQUEST_TIMEOUT_MILLIS = 0;
public static final int DEFAULT_MAX_CONN_PER_ROUTE = 10;
public static final int DEFAULT_MAX_CONN_TOTAL = 30;

Expand Down Expand Up @@ -193,7 +199,7 @@ public CloseableHttpAsyncClient run() {
}

private CloseableHttpAsyncClient createHttpClient() {
//default timeouts are all infinite
//default timeouts are all infinite, except the RequestTimeout which is explicitly disabled.
RequestConfig.Builder requestConfigBuilder = RequestConfig.custom()
.setConnectTimeout(DEFAULT_CONNECT_TIMEOUT_MILLIS)
.setSocketTimeout(DEFAULT_SOCKET_TIMEOUT_MILLIS)
Expand Down