Add POM generation for meta-plugins #28319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a POM generation task for the ZIP distribution for meta-plugins. With this change we also modify MetaPluginBuildPlugin to extend BuildPlugin (because we need POM generation configuration from there), remove standalone and REST test plugins, and manually create an integTest task. To simplify this, we abstract out some shared code from PluginBuildPlugin so that it can be reused in MetaPluginBuildPlugin.
jasontedor
added
blocker
review
:Delivery/Build
rjernst
reviewed
Jan 21, 2018
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Hrm, I don't think meta plugins should extend from BuildPlugin. They should not have any code (and build plugin is for a Java code). Meta plugins don't build a jar, they simply zip the zips from other plugins. I think we can just add pom generation directly?
Member
|
@jasontedor I opened #28321 with my proposed alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a POM generation task for the ZIP distribution for meta-plugins. With this change we also modify MetaPluginBuildPlugin to extend BuildPlugin (because we need POM generation configuration from there), remove standalone and REST test plugins, and manually create an integTest task. To simplify this, we abstract out some shared code from PluginBuildPlugin so that it can be reused in MetaPluginBuildPlugin.