Use Gradle wrapper when building BWC #28138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the BWC build to invoke the Gradle wrapper. The motivation for this is two-fold: - BWC versions might be dependent on a different version of Gradle than the current version of Gradle - in a follow-up we are going to need to be able to set JAVA_HOME to a different value than the current value of JAVA_HOME
Member
Author
The motivation here is in the change to require the JDK 9 compiler, we will continue to want to build 5.6 and 6.1 with the JDK 8 compiler so we need to push |
rjernst
approved these changes
Jan 8, 2018
distribution/bwc/build.gradle
Outdated
| File bwcRpm = file("${checkoutDir}/distribution/rpm/build/distributions/elasticsearch-${bwcVersion}.rpm") | ||
| File bwcZip = file("${checkoutDir}/distribution/zip/build/distributions/elasticsearch-${bwcVersion}.zip") | ||
| task buildBwcVersion(type: GradleBuild) { | ||
| task buildBwcVersion(type: Exec) { Exec exec -> |
Member
There was a problem hiding this comment.
Any reason you made this configuration a closure taking the task?
Member
Author
There was a problem hiding this comment.
Oops, that was leftover debugging. I removed this in a follow-up commit in this PR.
jasontedor
added a commit
that referenced
this pull request
Jan 9, 2018
This commit modifies the BWC build to invoke the Gradle wrapper. The motivation for this is two-fold: - BWC versions might be dependent on a different version of Gradle than the current version of Gradle - in a follow-up we are going to need to be able to set JAVA_HOME to a different value than the current value of JAVA_HOME Relates #28138
ywelsch
added a commit
that referenced
this pull request
Jan 9, 2018
ywelsch
added a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the BWC build to invoke the Gradle wrapper. The motivation for this is two-fold:
Relates #28065, #28071