remove deprecated percolator map_unmapped_fields_as_string setting #28060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Search Relevance/Percolator
martijnvg
force-pushed
the
remove_percolator_map_unmapped_fields_as_string_setting
branch
from
c357fff to
1d35b53
Compare
Contributor
|
Silly question: since it is just a rename of the setting, can it be done automatically for users upon upgrade? |
Member
Author
|
@jpountz I think we need to have infrastructure for this? Otherwise it will require additional custom code in percolator to achieve that. |
jpountz
approved these changes
Feb 1, 2018
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
OK I see the old setting had been deprecated for some time now. It works for me.
martijnvg
force-pushed
the
remove_percolator_map_unmapped_fields_as_string_setting
branch
from
1d35b53 to
ecb1d07
Compare
This was referenced Dec 10, 2018
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 21, 2019
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.