Skip to content

Conversation

@cbuescher
Copy link
Member

Add section to significant_text documentation mentioning that it currently
does not support use on nested objects.

Relates to #28050

Add section to `significant_text` documentation mentioning that it currently
does not support use on nested objects.

Relates to elastic#28050
@cbuescher
Copy link
Member Author

@markharwood I gave this a try, not sure if I've gotten the reason for this not being supported completely right, so happy about any suggestions on rewording.


===== No support for nested objects

The significant_text aggregation currently also cannot be use with text fields in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cannot be used" rather than "use"

@markharwood
Copy link
Contributor

Added a comment but otherwise LGTM

@cbuescher cbuescher merged commit 556d77c into elastic:master Jan 3, 2018
cbuescher pushed a commit that referenced this pull request Jan 3, 2018
#28052)

Add section to `significant_text` documentation mentioning that it currently
does not support use on nested objects.

Relates to #28050
cbuescher pushed a commit that referenced this pull request Jan 3, 2018
#28052)

Add section to `significant_text` documentation mentioning that it currently
does not support use on nested objects.

Relates to #28050
cbuescher pushed a commit that referenced this pull request Jan 3, 2018
#28052)

Add section to `significant_text` documentation mentioning that it currently
does not support use on nested objects.

Relates to #28050
martijnvg added a commit that referenced this pull request Jan 4, 2018
* es/master: (53 commits)
  Bump compat version for local depdendent test to 6.2.0
  Pass `java.locale.providers=COMPAT` to Java 9 onwards (#28080)
  Allow shrinking of indices from a previous major (#28076)
  Remove deprecated exceptions (#28059)
  Add Writeable.Reader support to TransportResponseHandler (#28010)
  Plugins: Add plugin extension capabilities (#27881)
  Fix cluster.routing.allocation.enable and cluster.routing.rebalance.enable casing (#28037)
  [Test] Fix scores for dcg in RankEvalRequestIT and RankEvalYamlIT
  [Docs] Add note on limitation for significant_text with nested objects (#28052)
  Enable convert processor to support Long and Double. (#27957)
  Enable Wildfly tests on JDK 9 and JDK 10
  [Test] Fix allowed delta for calculated scores in DiscountedCumulativeGainTests
  [Test] Mute DiscountedCumulativeGainTests on ARM
  Only bind loopback addresses when binding to local
  Fix assertion in Wildfly build
  Fix typo in comment in Wildfly build
  Use ephemeral ports in Wildfly tests
  Update fuzzy-query.asciidoc (#28032)
  Just another elasticsearch library (#27996)
  Disable nio test transport (#28028)
  ...
martijnvg added a commit that referenced this pull request Jan 4, 2018
* es/6.x: (48 commits)
  Bump compat version for local depdendent test to 6.2.0
  Pass `java.locale.providers=COMPAT` to Java 9 onwards (#28080)
  Allow shrinking of indices from a previous major (#28076)
  Add Writeable.Reader support to TransportResponseHandler (#28010)
  Fix cluster.routing.allocation.enable and cluster.routing.rebalance.enable casing (#28037)
  [Test] Fix scores for dcg in RankEvalRequestIT and RankEvalYamlIT
  [Docs] Add note on limitation for significant_text with nested objects (#28052)
  [Test] Fix allowed delta for calculated scores in DiscountedCumulativeGainTests
  Enable convert processor to support Long and Double. (#27957)
  Enable Wildfly tests on JDK 9 and JDK 10
  update ingest-attachment to use Tika 1.17 and newer deps (#27824)
  Only bind loopback addresses when binding to local
  Fix assertion in Wildfly build
  Fix typo in comment in Wildfly build
  Use ephemeral ports in Wildfly tests
  Update fuzzy-query.asciidoc (#28032)
  Add node id to shard failure message (#28024)
  Introduce limit to the number of terms in Terms Query (#27968)
  Upgrade Gradle Shadow plugin to 2.0.2
  Upgrade to JMH 1.19
  ...
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants