Skip to content

Conversation

@softwaredoug
Copy link
Contributor

ES now requires gradle 4.3, change contributing.md to match

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

ES now requires gradle 4.3, change contributing.md to match
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@softwaredoug
Copy link
Contributor Author

FTR my company (opensource connections, github org o19s) has signed the CLA

@DaveCTurner
Copy link
Contributor

@elasticmachine please test this

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 507aac4 into elastic:master Dec 26, 2017
DaveCTurner pushed a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 26, 2017
DaveCTurner pushed a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 26, 2017
DaveCTurner pushed a commit to DaveCTurner/elasticsearch that referenced this pull request Dec 26, 2017
@DaveCTurner
Copy link
Contributor

6.0 -> 7872aaa
6.1 -> 1e53212
6.x -> 3b74b9a
master -> 507aac4

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.0.3 v6.1.2 v6.2.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants