Fix composite aggregation when after term is missing in the shard #27936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug when a keyword term in the `after` key is not present in the shard. In this case the global ord of the document values are compared with the insertion point of the `after` keyword and values that are equal to the insertion point should be considered "after" the top value.
jimczi
changed the title
jpountz
approved these changes
Dec 22, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
Looks good. Alternatively, I'm wondering whether we should multiply all ords by 2 in order to be actually able to insert ords all the time.
Contributor
Author
|
Thanks @jpountz
That's also an alternative. I am in the middle of a refactoring so I'll change the logic in the mean time. |
jimczi
added a commit
that referenced
this pull request
Dec 26, 2017
…7936) This change fixes a bug when a keyword term in the `after` key is not present in the shard. In this case the global ord of the document values are compared with the insertion point of the `after` keyword and values that are equal to the insertion point should be considered "after" the top value.
jimczi
added a commit
that referenced
this pull request
Dec 26, 2017
jimczi
added a commit
that referenced
this pull request
Dec 26, 2017
…7936) This change fixes a bug when a keyword term in the `after` key is not present in the shard. In this case the global ord of the document values are compared with the insertion point of the `after` keyword and values that are equal to the insertion point should be considered "after" the top value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when a keyword term in the
afterkey is not present in the shard.In this case the global ord of the document values are compared with the insertion point of the
afterkeyword and values that are equal to the insertion point should be considered "after" the top value.