Skip to content

Conversation

@jasontedor
Copy link
Member

Previously we would unidle a primary shard during recovery in case the recovery target would miss a background global checkpoint sync. However, the background global checkpoint syncs are no longer tied to the primary shard falling idle and so this unidling is no longer needed.

Relates #26591

Previously we would unidle a primary shard during recovery in case the
recovery target would miss a background global checkpoint sync. However,
the background global checkpoint syncs are no longer tied to the primary
shard falling idle and so this unidling is no longer needed.
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@jasontedor jasontedor merged commit 6bc40e4 into elastic:master Dec 11, 2017
jasontedor added a commit that referenced this pull request Dec 11, 2017
Previously we would unidle a primary shard during recovery in case the
recovery target would miss a background global checkpoint sync. However,
the background global checkpoint syncs are no longer tied to the primary
shard falling idle and so this unidling is no longer needed.

Relates #27757
jasontedor added a commit that referenced this pull request Dec 11, 2017
Previously we would unidle a primary shard during recovery in case the
recovery target would miss a background global checkpoint sync. However,
the background global checkpoint syncs are no longer tied to the primary
shard falling idle and so this unidling is no longer needed.

Relates #27757
@jasontedor jasontedor deleted the remove-unidle branch December 11, 2017 18:27
@clintongormley clintongormley added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. and removed :Sequence IDs labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v6.1.1 v6.2.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants