Skip to content

Conversation

@dingminyi
Copy link

Hi Team,
Found a tiny imperfection in indices.put_settings.json, please kindly review.

Thanks!
Minyi

@karmi
Copy link
Contributor

karmi commented Dec 8, 2017

Hi @dingminyi, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@dingminyi
Copy link
Author

Hi Karmi,
Thanks for your reminder! Just added that email to my github account.

@dingminyi dingminyi closed this Dec 8, 2017
@dingminyi dingminyi reopened this Dec 8, 2017
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@karmi
Copy link
Contributor

karmi commented Dec 8, 2017

Hi, something weird is going with the CLA check, because if you have added the e-mail from the commit to your Github profile, the check should be green. We've had a similar issue yesterday, we'll look into it.

@dingminyi
Copy link
Author

Hi Karmi,
Thank you for your reply, I added the email after I sent the PR, maybe that's the reason?

Thanks!

@karmi
Copy link
Contributor

karmi commented Dec 8, 2017

Sadly no, the timing shouldn't matter...

@martijnvg martijnvg self-assigned this Dec 8, 2017
@dingminyi
Copy link
Author

Hi Karmi,
Got it. Waiting for the updates, thanks! :)

@colings86 colings86 added >non-issue :Core/Infra/REST API REST infrastructure and utilities labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@javanna
Copy link
Member

javanna commented May 7, 2018

this got fixed in the meantime by #29327 , thanks anyways @dingminyi !

@javanna javanna closed this May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting CLA :Core/Infra/REST API REST infrastructure and utilities >non-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants