Fix issue where the incorrect buffers are written #27695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to elastic#27551. That commit introduced a bug where the incorrect byte buffers would be returned when we attempted a write. This commit fixes the logic.
Tim-Brooks
added
:Distributed Coordination/Network
Tim-Brooks
added a commit
that referenced
this pull request
Dec 7, 2017
This is a followup to #27551. That commit introduced a bug where the incorrect byte buffers would be returned when we attempted a write. This commit fixes the logic.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Dec 7, 2017
This is a follow up to elastic#27695. This commit adds a test checking that across multiple writes using multiple buffers, a write operation properly keeps track of which buffers still need to be written.
Tim-Brooks
added a commit
that referenced
this pull request
Dec 7, 2017
This is a follow up to #27695. This commit adds a test checking that across multiple writes using multiple buffers, a write operation properly keeps track of which buffers still need to be written.
Tim-Brooks
added a commit
that referenced
this pull request
Dec 7, 2017
This is a follow up to #27695. This commit adds a test checking that across multiple writes using multiple buffers, a write operation properly keeps track of which buffers still need to be written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #27551. That commit introduced a bug where the
incorrect byte buffers would be returned when we attempted a write. This
commit fixes the logic.