Correct two equality checks on incomparable types

[rneatherway]

Hi! I was browsing the project on lgtm.com and came across a couple of alerts where different types are being compared using .equals(). In these cases the fix seemed pretty obvious so I've gone ahead and done it here.

I've already gone ahead and signed the CLA. I hope these fixes are useful!

Full disclosure -- I am one of the developers working on lgtm.com

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cbuescher]

@rneatherway thanks for reporting this, both cases look like they should be fixed too me. Also /cc @nknize and @jdconrad to make sure they agree. Those cases should probably also get some related unit tests.
Will kick of a test run in a minute and run the CLA checker once again to see why it still fails.

[cbuescher]

@elasticmachine test this please

[cbuescher]

@rneatherway your CLA signature is in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

[rneatherway]

I already have both the one I signed with and the one I committed with associated with my Github profile, is there anything else I need to do?

[cbuescher]

Thanks, normally no. Maybe the internal checker just needs to catch up.

[nknize]

LGTM

[rneatherway]

Is there any way to refresh the CLA check? If it is easier I can just resign it with the email address I used to commit here.

[cbuescher]

@rneatherway I tried retriggering, usually it works, trying to find out whats wrong and waiting for feedback atm.

[karmi]

Hi @rneatherway, I maintain the CLA checker service on our side, and wanted to ask if you can double check that the e-mail from the Git commit is indeed added to your Github profile. Normally, as @cbuescher says, that's enough for the CLA check to be green, but is seems to fail in this case...

[rneatherway]

Yes I have, it is even my primary email address. I think if it wasn't on my profile then Github wouldn't have known that the commit was by rneatherway.

[karmi]

@rneatherway, I agree, that's how it works. However, I don't have any good explanation why this PR isn't then green-marked, as it normally happens... Would be so kind and help us to debug this by trying to a) signing the CLA with the same e-mail as in Git, b) changing the Git email to the one in signature?

[rneatherway]

Sure, I've done 'a'

[cbuescher]

@rneatherway thanks, looks all green now, I will merge this in.

[karmi]

@rneatherway, many thanks!, I still don't know why this happened, but it's good to know there's a bit of a "brute force" solution like this one.

[rneatherway]

Great! I'll see if I can fix anything else.