Skip to content

Conversation

@jasontedor
Copy link
Member

This commit adds a note to the 6.2 docs for the addition of out-of-the-box GC logging.

Relates #27610

This commit adds a note to the 6.2 docs for the addition of
out-of-the-box GC logging.
@jasontedor jasontedor added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes v6.2.0 labels Dec 3, 2017
@jasontedor jasontedor requested a review from rjernst December 5, 2017 05:25
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one suggestion.

-XX:+PrintGCDateStamps
-XX:+PrintTenuringDistribution
-XX:+PrintGCApplicationStoppedTime
-Xloggc:logs/gc.log or /var/log/elasticsearch/gc.log <1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the "or" part in the description below, so that this can more easily be copy/pasted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather copy-pasting not be encouraged here because the right value of this setting depends on whether or not a user is using a package distribution versus an archive distribution?

@jasontedor jasontedor merged commit 5c8c0bc into elastic:6.x Dec 8, 2017
@jasontedor jasontedor deleted the gc-logging-migration branch December 8, 2017 17:26
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team v6.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants