Skip to content

Transpose expected and actual, and remove duplicate info from message. #27515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2017
Merged

Transpose expected and actual, and remove duplicate info from message. #27515

merged 1 commit into from
Nov 24, 2017

Conversation

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Nov 24, 2017

Previously:

   > Throwable #1: java.lang.AssertionError: Expected all shards successful but got successful [8] total [9]
   > Expected: <8>
   >      but: was <9>

Now:

   > Throwable #1: java.lang.AssertionError: Expected all shards successful
   > Expected: <9>
   >      but: was <8>

@DaveCTurner
Transpose expected and actual, and remove duplicate info from message.
ea98ddc 
Previously:
```
   > Throwable #1: java.lang.AssertionError: Expected all shards successful but got successful [8] total [9]
   > Expected: <8>
   >      but: was <9>
```

Now:
```
   > Throwable #1: java.lang.AssertionError: Expected all shards successful
   > Expected: <9>
   >      but: was <8>
```
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests v6.2.0 v7.0.0 labels Nov 24, 2017
@DaveCTurner DaveCTurner requested a review from s1monw November 24, 2017 10:58
jasontedor
jasontedor approved these changes Nov 24, 2017
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaveCTurner DaveCTurner merged commit 00867e6 into elastic:master Nov 24, 2017
@DaveCTurner DaveCTurner deleted the 2017-11-24-assertAllSuccessful-messages branch November 24, 2017 17:47
@DaveCTurner
Copy link
Contributor Author

DaveCTurner commented Nov 24, 2017

master -> ea98ddc
6.x -> c9e6524

Thanks both.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 24, 2017
@jasontedor
Merge branch 'master' into halt-bug
d487b9b 
* master:
  Revert "Adjust CombinedDeletionPolicy for multiple commits (elastic#27456)"
  Transpose expected and actual, and remove duplicate info from message. (elastic#27515)
  [DOCS] Fixed broken link in breaking changes
  Backport wait_for_initialiazing_shards to cluster health API
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 24, 2017
@jasontedor
Merge branch 'master' into cli-logging
3364a01 
* master:
  Revert "Adjust CombinedDeletionPolicy for multiple commits (elastic#27456)"
  Transpose expected and actual, and remove duplicate info from message. (elastic#27515)
  [DOCS] Fixed broken link in breaking changes
  Backport wait_for_initialiazing_shards to cluster health API
jasontedor added a commit that referenced this pull request Nov 27, 2017
@jasontedor
Merge branch 'master' into ccr
11d46ad 
* master:
  Skip shard refreshes if shard is `search idle` (#27500)
  Remove workaround in translog rest test (#27530)
  inner_hits: Return an empty _source for nested inner hit when filtering on a field that doesn't exist.
  percolator: Avoid TooManyClauses exception if number of terms / ranges is exactly equal to 1024
  Dedup translog operations by reading in reverse (#27268)
  Ensure logging is configured for CLI commands
  Ensure `doc_stats` are changing even if refresh is disabled (#27505)
  Fix classes that can exit
  Revert "Adjust CombinedDeletionPolicy for multiple commits (#27456)"
  Transpose expected and actual, and remove duplicate info from message. (#27515)
  [DOCS] Fixed broken link in breaking changes
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasontedor jasontedor jasontedor approved these changes

+1 more reviewer

@s1monw s1monw s1monw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>test Issues or PRs that are addressing/adding tests v6.2.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DaveCTurner @s1monw @jasontedor @jimczi