Skip to content

Log primary-replica resync failures #27421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2017
Merged

Log primary-replica resync failures #27421

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
367be38
Log primary-replica resync failures
jasontedor Nov 17, 2017
ac87aa8
warn -> info
jasontedor Nov 17, 2017
bd23fdb
annotation
jasontedor Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/main/java/org/elasticsearch/action/resync/TransportResyncReplicationAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@
*/
package org.elasticsearch.action.resync;

import org.apache.logging.log4j.message.ParameterizedMessage;
import org.elasticsearch.Version;
import org.elasticsearch.action.ActionListener;
import org.elasticsearch.action.support.ActionFilters;
import org.elasticsearch.action.support.TransportActions;
import org.elasticsearch.action.support.replication.ReplicationOperation;
import org.elasticsearch.action.support.replication.ReplicationResponse;
import org.elasticsearch.action.support.replication.TransportReplicationAction;
import org.elasticsearch.action.support.replication.TransportWriteAction;
import org.elasticsearch.cluster.action.shard.ShardStateAction;
Expand Down Expand Up @@ -158,6 +160,15 @@ public String executor() {

@Override
public void handleResponse(ResyncReplicationResponse response) {
final ReplicationResponse.ShardInfo.Failure[] failures = response.getShardInfo().getFailures();
// noinspection ForLoopReplaceableByForEach
for (int i = 0; i < failures.length; i++) {
final ReplicationResponse.ShardInfo.Failure f = failures[i];
logger.info(
new ParameterizedMessage(
"{} primary-replica resync to replica on node [{}] failed", f.fullShardId(), f.nodeId()),
f.getCause());
}
listener.onResponse(response);
}

Expand Down