Skip to content

Conversation

@jasontedor
Copy link
Member

Gradle 5.0 will remove support for colons in configuration and task
names. This commit fixes this for our build by removing all current uses
of colons in configuration and task names.

Relates #27250

Gradle 5.0 will remove support for colons in configuration and task
names. This commit fixes this for our build by removing all current uses
of colons in configuration and task names.
@jasontedor
Copy link
Member Author

jasontedor commented Nov 7, 2017

This removes many lines of warnings like:

The name '_transitive_org.openjdk.jmh:jmh-core:1.17.3' contains at least one of the following characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is scheduled to be removed in Gradle 5.0.
	at build_a92y8m4ak5gicu9a6zp2j6xfn$_run_closure1.doCall(/Users/dpilato/Documents/Elasticsearch/dev/elasticsearch/es-master/elasticsearch/benchmarks/build.gradle:52)
	(Run with --stacktrace to get the full stack trace of this deprecation warning.)

and

The name '_plugin_integTestCluster_:plugins:analysis-icu' contains at least one of the following characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is scheduled to be removed in Gradle 5.0.

and

The task name 'addPrincipal#hdfs/hdfs.build.elastic.co' contains at least one of the following characters: [ , /, \, :, <, >, ", ?, *, |]. This has been deprecated and is scheduled to be removed in Gradle 5.0.
        at build_29krsyfke8ucv8x0as9l09y6s.run(/Users/jason/src/elastic/elasticsearch/plugins/repository-hdfs/build.gradle:109)
        (Run with --stacktrace to get the full stack trace of this deprecation warning.)

that are emitted during configuration.

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit 58a28da into elastic:master Nov 8, 2017
jasontedor added a commit that referenced this pull request Nov 8, 2017
Gradle 5.0 will remove support for colons in configuration and task
names. This commit fixes this for our build by removing all current uses
of colons in configuration and task names.

Relates #27305
jasontedor added a commit that referenced this pull request Nov 8, 2017
Gradle 5.0 will remove support for colons in configuration and task
names. This commit fixes this for our build by removing all current uses
of colons in configuration and task names.

Relates #27305
@jasontedor jasontedor deleted the remove-colons-from-names branch November 8, 2017 20:25
jasontedor added a commit that referenced this pull request Nov 8, 2017
Gradle 5.0 will remove support for colons in configuration and task
names. This commit fixes this for our build by removing all current uses
of colons in configuration and task names.

Relates #27305
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
@drewr drewr mentioned this pull request Dec 18, 2017
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v5.6.5 v6.0.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants