Allow ip_range to accept CIDR notation #27192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
:Search Foundations/Mapping
jpountz
approved these changes
Nov 3, 2017
Contributor
jpountz
left a comment
jpountz
left a comment
There was a problem hiding this comment.
Change looks good, I left a comment about the test.
Contributor
There was a problem hiding this comment.
Can you test something that is not byte-aligned, like /15 or /17? We used to have bugs in those cases.
Contributor
Author
|
@jpountz done, added the non-aligned test cases as well :) |
original-brownbear
force-pushed
the
26260
branch
from
1099934 to
88e84e9
Compare
Contributor
Author
|
Same as in the other PR, failed BWC => rebased against master to fix. |
Contributor
Author
|
@dakrone this one's green after rebase now as well :) |
dakrone
pushed a commit
that referenced
this pull request
Nov 3, 2017
Closed
martijnvg
added a commit
that referenced
this pull request
Nov 4, 2017
* es/master: Fix snapshot getting stuck in INIT state (#27214) Add an example of dynamic field names (#27255) #26260 Allow ip_range to accept CIDR notation (#27192) #27189 Fixed rounding of bounds in scaled float comparison (#27207) Add support for Gradle 4.3 (#27249) Fixes QueryStringQueryBuilderTests build: Fix setting the incorrect bwc version in mixed cluster qa module [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC Adjust assertions for sequence numbers BWC tests Do not create directories if repository is readonly (#26909) [Test] Fix InternalStatsTests [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery Uses norms for exists query if enabled (#27237) Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
martijnvg
added a commit
that referenced
this pull request
Nov 4, 2017
* 6.x: Add an example of dynamic field names (#27255) fixed checkstyle violation #26260 Allow ip_range to accept CIDR notation (#27192) #27189 Fixed rounding of bounds in scaled float comparison (#27207) [TEST] Fix failing exists query test test: Do not run old parent/child tests against a cluster with minimum version greater than 6.0.0 Add support for Gradle 4.3 (#27249) Fixes QueryStringQueryBuilderTests build: Fix setting the incorrect bwc version in mixed cluster qa module fix compil after backport [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC Adjust assertions for sequence numbers BWC tests Do not create directories if repository is readonly (#26909) [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery Uses norms for exists query if enabled (#27237) Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at #26260 :
org.elasticsearch.search.aggregations.bucket.range.IpRangeAggregationBuilder.Range#Range(java.lang.String, java.lang.String)for the parsing (with some minor simplifications that could be made here by fixing the include/exclude behaviour of the boundaries)IpRangeFieldMapperTestssince there were only (at least as far as I could find) generic test classes that covered allRangetypes in a loop that applied here