Skip to content

Conversation

@karmi
Copy link
Contributor

@karmi karmi commented Oct 5, 2017

The terminate_after parameter has been missing from the REST specification.

karmi pushed a commit to elastic/elasticsearch-ruby that referenced this pull request Oct 5, 2017
Add `terminate_after` parameter to the Count action to be able to specify
the maximum count for each shard, upon reaching which the query execution
will terminate early.

Also update the link to Elasic Count API guide.

Closes #442

Related: elastic/elasticsearch#26895
karmi pushed a commit to elastic/elasticsearch-ruby that referenced this pull request Oct 5, 2017
Add `terminate_after` parameter to the Count action to be able to specify
the maximum count for each shard, upon reaching which the query execution
will terminate early.

Also update the link to Elasic Count API guide.

Closes #442

Related: elastic/elasticsearch#26895
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karmi karmi self-assigned this Oct 8, 2017
@karmi karmi added :Core/Infra/REST API REST infrastructure and utilities >test Issues or PRs that are addressing/adding tests v5.6.4 v6.0.0 v6.1.0 v7.0.0 labels Oct 8, 2017
@karmi karmi closed this in 6825caf Oct 8, 2017
karmi added a commit that referenced this pull request Oct 8, 2017
karmi added a commit that referenced this pull request Oct 8, 2017
karmi added a commit that referenced this pull request Oct 8, 2017
@karmi
Copy link
Contributor Author

karmi commented Oct 8, 2017

Merged into 5.6, 6.0 and 6.x branches.

@karmi karmi deleted the add-terminate_after-to-count branch October 8, 2017 12:15
@javanna javanna added v5.6.3 and removed v5.6.4 labels Oct 9, 2017
@lcawl lcawl added v6.0.0-rc2 and removed v6.0.0 labels Oct 30, 2017
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/REST API REST infrastructure and utilities >test Issues or PRs that are addressing/adding tests v5.6.3 v6.0.0-rc2 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants