Skip to content

Conversation

@jasontedor
Copy link
Member

This commit upgrades the Log4j dependency, picking up a fix for an issue with handling stack traces on JDK 9.

Relates apache/logging-log4j2#109, relates #26464, relates #26467

This commit upgrades the Log4j dependency, picking up a fix for an issue
with handling stack traces on JDK 9.
@jasontedor
Copy link
Member Author

Since our PR builds do not test on JDK 9:

07:34:22 ⌂61% [jason:~/src/elastic/elasticsearch] log4j-2.9.1+ ± JAVA_HOME=`/usr/libexec/java_home -v 9` gradle :qa:evil-tests:test -Dtests.class=org.elasticsearch.common.logging.EvilLoggerTests
.
.
.
=======================================
Elasticsearch Build Hamster says Hello!
=======================================
  Gradle Version        : 4.1
  OS Info               : Mac OS X 10.12.6 (x86_64)
  JDK Version           : Oracle Corporation 9 [Java HotSpot(TM) 64-Bit Server VM 9+181]
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home
  Random Testing Seed   : 70A4BA63301F831E
.
.
.
> Task :qa:evil-tests:test
Slow Tests Summary:
 15.44s | org.elasticsearch.common.logging.EvilLoggerTests

==> Test Summary: 1 suite, 9 tests
   [junit4] JVM J0:     0.62 ..    16.76 =    16.14s
   [junit4] Execution time total: 16 seconds
   [junit4] Tests summary: 1 suite, 9 tests


BUILD SUCCESSFUL in 1m 41s
15 actionable tasks: 10 executed, 5 up-to-date
07:36:06 ⌂83% [jason:~/src/elastic/elasticsearch] log4j-2.9.1+ ± 

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this upstream! You are such a good citizen.

@jasontedor jasontedor removed the v6.0.0 label Sep 22, 2017
@jasontedor jasontedor merged commit 2e63a13 into elastic:master Sep 22, 2017
jasontedor added a commit that referenced this pull request Sep 22, 2017
This commit upgrades the Log4j dependency, picking up a fix for an issue
with handling stack traces on JDK 9.

Relates #26750
@jasontedor jasontedor deleted the log4j-2.9.1 branch September 22, 2017 15:58
jasontedor added a commit that referenced this pull request Sep 22, 2017
This commit upgrades the Log4j dependency, picking up a fix for an issue
with handling stack traces on JDK 9.

Relates #26750
jasontedor added a commit that referenced this pull request Sep 22, 2017
This commit upgrades the Log4j dependency, picking up a fix for an issue
with handling stack traces on JDK 9.

Relates #26750
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants