Skip to content

Fix incomplete sentences in parent-join docs #26623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Fix incomplete sentences in parent-join docs #26623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38ee3f9
Fix incomplete sentences in parent-join docs
jimczi Sep 13, 2017
8ff9428
fix style
jimczi Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docs/reference/mapping/types/parent-join.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ PUT my_index

To index a document with a join, the name of the relation and the optional parent
of the document must be provided in the `source`.
For instance the following creates two parent documents in the `question` context:
For instance the following example creates two `parent` documents in the `question` context:

[source,js]
--------------------------------------------------
Expand Down Expand Up @@ -85,8 +85,7 @@ must be added in the `_source`.
WARNING: It is required to index the lineage of a parent in the same shard so you must
always route child documents using their greater parent id.

For instance the following index two children documents pointing to the same parent `1`
with a `routing` value equals to the `id` of the parent:
For instance the following example shows how to index two `child` documents:

[source,js]
--------------------------------------------------
Expand All @@ -111,7 +110,7 @@ PUT my_index/doc/4?routing=1&refresh
// CONSOLE
// TEST[continued]

<1> This child document must be on the same shard than its parent
<1> The routing value is mandatory because parent and child documents must be indexed on the same shard
<2> `answer` is the name of the join for this document
<3> The parent id of this child document

Expand Down