Update removal_of_types.asciidoc #26614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix link to [parent-child relationship]
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cbuescher
requested changes
Sep 13, 2017
|
|
||
| Mapping types were also used to establish a | ||
| /guide/en/elasticsearch/reference/5.4/mapping-parent-field.html[parent-child relationship] | ||
| https://www.elastic.co/guide/en/elasticsearch/reference/5.4/mapping-parent-field.html[parent-child relationship] |
Member
There was a problem hiding this comment.
I think it whould be better to use the asciidoc syntax for internal cross-references (<<url,link text>>) so we keep linking the current version etc... The page that the hard link refers to has the section title mapping-parent-field, so the link should be <<mapping-parent-field,parent-child relationship>>
Member
|
@danochoa thanks for opening this PR. I left a comment on how to improve the linking to other parts of the document. After you changed this, would you also sign the CLA so we can merge the PR? |
use the asciidoc syntax for internal cross-references on "parent-child relationship"
Contributor
Author
|
@cbuescher thanks for the feedback, I made the change and signed the CLA |
cbuescher
pushed a commit
that referenced
this pull request
Sep 14, 2017
Fix link to [parent-child relationship].
cbuescher
pushed a commit
that referenced
this pull request
Sep 14, 2017
Fix link to [parent-child relationship].
cbuescher
pushed a commit
that referenced
this pull request
Sep 14, 2017
Fix link to [parent-child relationship].
jasontedor
added a commit
to synhershko/elasticsearch
that referenced
this pull request
Sep 14, 2017
* master: (39 commits) [Docs] Correct typo in removal_of_types.asciidoc (elastic#26646) [Docs] "The the" is a great band, but ... (elastic#26644) Move all repository-azure classes under one single package (elastic#26624) [Docs] Update link in removal_of_types.asciidoc (elastic#26614) Fix percolator highlight sub fetch phase to not highlight query twice (elastic#26622) Refactor bootstrap check results and error messages Add BootstrapContext to expose settings and recovered state to bootstrap checks (elastic#26628) [Tests] Removing skipping tests in search rest tests Initialize checkpoint tracker with allocation ID Move non-core mappers to a module. (elastic#26549) [Docs] Clarify size parameter in Completion Suggester doc (elastic#26617) Add soft limit on allowed number of script fields in request (elastic#26598) Remove MapperService#dynamic. (elastic#26603) Fix incomplete sentences in parent-join docs (elastic#26623) More efficient encoding of range fields. (elastic#26470) Ensure module is bundled before installing in tests Add boolean similarity to built in similarity types (elastic#26613) [Tests] Remove skip tests in search/30_limits.yml Let search phases override max concurrent requests Add a soft limit for the number of requested doc-value fields (elastic#26574) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix link to [parent-child relationship]
gradle check?