Add missing catch arguments to the rest api spec #26536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
approved these changes
Sep 7, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left one comment. It otherwise looks great. Address how you see fit and you can merge without another review from me.
| `request_timeout`:: a 408 response from ES | ||
| `conflict`:: a 409 response from ES | ||
| `unavailable`:: a 503 response from ES | ||
| `request`:: a generic error response from ES |
Member
There was a problem hiding this comment.
I wonder if this should be clarified to say that it does not include 401, 403, 404, 408, and 409 and is otherwise any 400 or 500?
Contributor
Author
|
|
hub-cap
added a commit
that referenced
this pull request
Sep 14, 2017
hub-cap
added a commit
that referenced
this pull request
Sep 14, 2017
hub-cap
added a commit
that referenced
this pull request
Sep 14, 2017
hub-cap
added a commit
that referenced
this pull request
Sep 14, 2017
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 16, 2017
* master: fix testSniffNodes to use the new error message Add check for invalid index in WildcardExpressionResolver (elastic#26409) Docs: Use single-node discovery.type for dev example Filter unsupported relation for range query builder (elastic#26620) Fix kuromoji default stoptags (elastic#26600) [Docs] Add description for missing fields in Reindex/Update/Delete By Query (elastic#26618) [Docs] Update ingest.asciidoc (elastic#26599) Better message text for ResponseException [DOCS] Remove edit link from ML node enable bwc testing fix StartRecoveryRequestTests.testSerialization Add bad_request to the rest-api-spec catch params (elastic#26539) Introduce a History UUID as a requirement for ops based recovery (elastic#26577) Add missing catch arguments to the rest api spec (elastic#26536)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.