-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Migrate migration docs from 6.0 to 7.0 #26227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since we only keep one version of migration docs and master is now on 7.0, we should migrate these so breaking changes can be added in the right place.
jasontedor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the docs build successfully.
|
I ran |
|
(I'll also build the entire doc set before merging) |
nik9000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
|
I meant an actual docs build with the Perl script. |
|
I suppose I must close #26111 then? |
They link to the migration guides, so they have to go.
|
@dadoonet ah whoops sorry! I totally didn't see your PR for this already, are you okay if I merge this one? I just verified it builds with the |
|
retest this please |
|
Sure. Just close mine. |
Since we only keep one version of migration docs and master is now on 7.0, we
should migrate these so breaking changes can be added in the right place.