Skip to content

Conversation

@dakrone
Copy link
Member

@dakrone dakrone commented Aug 15, 2017

Since we only keep one version of migration docs and master is now on 7.0, we
should migrate these so breaking changes can be added in the right place.

Since we only keep one version of migration docs and master is now on 7.0, we
should migrate these so breaking changes can be added in the right place.
@dakrone dakrone added >docs General docs changes v7.0.0 labels Aug 15, 2017
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the docs build successfully.

@dakrone
Copy link
Member Author

dakrone commented Aug 15, 2017

I ran gradle docs:check and everything checked out, thanks for the quick review :)

@dakrone
Copy link
Member Author

dakrone commented Aug 15, 2017

(I'll also build the entire doc set before merging)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@jasontedor
Copy link
Member

I meant an actual docs build with the Perl script.

@dadoonet
Copy link
Contributor

I suppose I must close #26111 then?

@dakrone
Copy link
Member Author

dakrone commented Aug 16, 2017

@dadoonet ah whoops sorry! I totally didn't see your PR for this already, are you okay if I merge this one? I just verified it builds with the build_docs.pl without any errors

@dakrone
Copy link
Member Author

dakrone commented Aug 16, 2017

retest this please

@dadoonet
Copy link
Contributor

Sure. Just close mine.

@dakrone dakrone merged commit cfad668 into elastic:master Aug 16, 2017
@dakrone dakrone deleted the remove-6x-migration-things branch December 13, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants