Remove static indices and repos and the scripts that create them #26109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
approved these changes
Aug 9, 2017
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
LGTM.
As much as a morn the loss of the fairly isolated test in InternalIndicesTests it does overlap with the full cluster restart and rolling restart tests.
Member
|
I'm also quite happy to see the binary blobs leave the repo. And happy to see that we no longer have to maintain them and the manual steps around building them. |
Two tests were still using the static indices: * IndexFolderUpgraderTests#testUpgradeRealIndex() * InternalEngineTests#testUpgradeOldIndex() I removed these tests too, because these tests functionally overlap with the full-cluster-restart qa tests. Relates to elastic#24939
martijnvg
force-pushed
the
remove_bwc_script_and_static_indices_and_repos
branch
from
ef71754 to
0e54603
Compare
Closed
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests were still using the static indices:
I removed these tests too, because these tests functionally overlap
with the full-cluster-restart qa tests.
Relates to #24939