Disallow the classic similarity on new indices.
#26016
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
:Search/Search
Contributor
Author
|
The current way similarities are implemented makes this change hard, I need to think more about it. |
jpountz
force-pushed
the
fix/remove_classic_similarity
branch
from
30c5b0b to
c6e20a4
Compare
The `classic` similarity used to rely on specific features like query normalization and coord factors, which were specific to this similarity and have been removed as the `bm25` similarity has now been the default similarity for some time. As a consequence, using the `classic` similarity could lead to depeptive scores, which is why we want to prevent users from using it on new indices. `bm25` is generally considered a superior option. Closes elastic#23208
jpountz
force-pushed
the
fix/remove_classic_similarity
branch
from
e1b16d6 to
086db4a
Compare
Member
|
@jpountz do you plan on reviving this or shall we close it? cc @elastic/es-search-aggs |
Contributor
Author
|
Superseded by #29187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
classicsimilarity used to rely on specific features like querynormalization and coord factors, which were specific to this similarity and
have been removed as the
bm25similarity has now been the default similarityfor some time. As a consequence, using the
classicsimilarity could leadto depeptive scores, which is why we want to prevent users from using it on new
indices.
bm25is generally considered a superior option.Closes #23208