Remove memlock suggestion from systemd service #25979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The systemd service file that ships with Elasticsearch installs on systemd-based systems contains a suggestion for setting LimitMEMLOCK if the user wants to enable bootstrap.memory_lock. However, this setting this in the installed service file goes against best practices for working with systemd, and goes against our existing documentation for how to set this. Therefore, we should not have this suggestion in the service file otherwise users might be led to think they should edit it there.
jasontedor
added
:Delivery/Packaging
nik9000
approved these changes
Jul 31, 2017
* master: Also skip JAVA_TOOL_OPTIONS on Windows Remove useless checks from evil JNA tests Add max file size bootstrap check
jasontedor
added a commit
that referenced
this pull request
Jul 31, 2017
The systemd service file that ships with Elasticsearch installs on systemd-based systems contains a suggestion for setting LimitMEMLOCK if the user wants to enable bootstrap.memory_lock. However, this setting this in the installed service file goes against best practices for working with systemd, and goes against our existing documentation for how to set this. Therefore, we should not have this suggestion in the service file otherwise users might be led to think they should edit it there. Relates #25979
jasontedor
added a commit
that referenced
this pull request
Jul 31, 2017
The systemd service file that ships with Elasticsearch installs on systemd-based systems contains a suggestion for setting LimitMEMLOCK if the user wants to enable bootstrap.memory_lock. However, this setting this in the installed service file goes against best practices for working with systemd, and goes against our existing documentation for how to set this. Therefore, we should not have this suggestion in the service file otherwise users might be led to think they should edit it there. Relates #25979
jasontedor
added a commit
that referenced
this pull request
Jul 31, 2017
The systemd service file that ships with Elasticsearch installs on systemd-based systems contains a suggestion for setting LimitMEMLOCK if the user wants to enable bootstrap.memory_lock. However, this setting this in the installed service file goes against best practices for working with systemd, and goes against our existing documentation for how to set this. Therefore, we should not have this suggestion in the service file otherwise users might be led to think they should edit it there. Relates #25979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The systemd service file that ships with Elasticsearch installs on systemd-based systems contains a suggestion for setting
LimitMEMLOCKif the user wants to enablebootstrap.memory_lock. However, this setting this in the installed service file goes against best practices for working with systemd, and goes against our existing documentation for how to set this. Therefore, we should not have this suggestion in the service file otherwise users might be led to think they should edit it there.