Skip to content

Conversation

@honourednihilist
Copy link
Contributor

Fixed bug that mapper_parsing_exception is thrown for numeric field with ignore_malformed=true when inserting "NaN", "Infinity" or "-Infinity" values

Closes #25289

…ith ignore_malformed=true when inserting "NaN", "Infinity" or "-Infinity" values
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@honourednihilist
Copy link
Contributor Author

I signed the CLA just right before creating this pull request.

@jpountz
Copy link
Contributor

jpountz commented Jul 31, 2017

@elasticmachine Test it please.

@jpountz
Copy link
Contributor

jpountz commented Jul 31, 2017

@honourednihilist I can see that you signed the CLA indeed, thanks!

@jpountz jpountz self-requested a review July 31, 2017 13:50
@honourednihilist
Copy link
Contributor Author

This bugfix affects org.elasticsearch.index.mapper.ScaledFloatFieldMapper, and I wanted to ask about org.elasticsearch.index.mapper.NumberFieldMapper. Should "NaN" or "Infinity" values be considered by regular NumberFieldMapper (not scaled) as malformed?

@jpountz
Copy link
Contributor

jpountz commented Jul 31, 2017

Yes, we recently agreed to reject such values, see #25534.

@jpountz jpountz merged commit 0848ffd into elastic:master Jul 31, 2017
jpountz pushed a commit that referenced this pull request Jul 31, 2017
…ith ignore_malformed=true when inserting "NaN", "Infinity" or "-Infinity" values (#25967)
jpountz pushed a commit that referenced this pull request Jul 31, 2017
…ith ignore_malformed=true when inserting "NaN", "Infinity" or "-Infinity" values (#25967)
jpountz pushed a commit that referenced this pull request Jul 31, 2017
…ith ignore_malformed=true when inserting "NaN", "Infinity" or "-Infinity" values (#25967)
@clintongormley clintongormley added :Search Foundations/Mapping Index mappings, including merging and defining field types >bug labels Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search Foundations/Mapping Index mappings, including merging and defining field types v5.6.0 v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants