Exit Windows scripts promptly on failure #25959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoking the elasticsearch-env.bat batch script on Windows, if the script exits due to an error (e.g., Java can not be found, or the wrong version of Java is found), then the script exits. Sadly, on Windows, this does not also terminate the caller, instead returning control. This means we have to explicitly exit so that is what we do in this commit.
jasontedor
added
:Delivery/Packaging
* master: Version option should display if snapshot Ignore JVM options before checking Java version Remove dead code for checking exclusive options Fix typo in Elasticsearch help Add version command to issue template Fix typo in Windows elasticsearch-env script Remove running outside of distribution check
tlrx
approved these changes
Jul 31, 2017
jasontedor
added a commit
that referenced
this pull request
Jul 31, 2017
When invoking the elasticsearch-env.bat batch script on Windows, if the script exits due to an error (e.g., Java can not be found, or the wrong version of Java is found), then the script exits. Sadly, on Windows, this does not also terminate the caller, instead returning control. This means we have to explicitly exit so that is what we do in this commit. Relates #25959
jasontedor
added a commit
that referenced
this pull request
Jul 31, 2017
When invoking the elasticsearch-env.bat batch script on Windows, if the script exits due to an error (e.g., Java can not be found, or the wrong version of Java is found), then the script exits. Sadly, on Windows, this does not also terminate the caller, instead returning control. This means we have to explicitly exit so that is what we do in this commit. Relates #25959
Member
Author
|
Thanks @tlrx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking the elasticsearch-env.bat batch script on Windows, if the script exits due to an error (e.g., Java can not be found, or the wrong version of Java is found), then the script exits. Sadly, on Windows, this does not also terminate the caller, instead returning control. This means we have to explicitly exit so that is what we do in this commit.