Cleanup IndexFieldData visibility #25900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we expose `IndexFieldDataService` outside of IndexService to do maintainance or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData via `QueryShardContext` that should encapsulate all access to it. This also ensures that we control all other functionality like cache clearing etc. This change also removes the `recycler` option from `ClearIndicesCacheRequest` this option is a no-op and should have been removed long ago.
jpountz
approved these changes
Jul 26, 2017
| private boolean requestCache = false; | ||
| private String[] fields = null; | ||
| private String[] fields = Strings.EMPTY_ARRAY; |
Contributor
There was a problem hiding this comment.
that change alone makes me happy
| indexFieldData.clearField(field); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I see you did not change that logic but it confuses me a bit as it seems we always clear fileddata even when fieldDataCache is false?
Contributor
Author
There was a problem hiding this comment.
yeah we are on the same page. I will open a followup with a BWC break
jimczi
approved these changes
Jul 26, 2017
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
LGTM for the code, tests failed to compile ;)
s1monw
added a commit
that referenced
this pull request
Jul 26, 2017
Today we expose `IndexFieldDataService` outside of IndexService to do maintenance or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData via `QueryShardContext` that should encapsulate all access to it. This also ensures that we control all other functionality like cache clearing etc. This change also removes the `recycler` option from `ClearIndicesCacheRequest` this option is a no-op and should have been removed long ago.
s1monw
added a commit
that referenced
this pull request
Jul 26, 2017
Today we expose `IndexFieldDataService` outside of IndexService to do maintenance or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData via `QueryShardContext` that should encapsulate all access to it. This also ensures that we control all other functionality like cache clearing etc. This change also removes the `recycler` option from `ClearIndicesCacheRequest` this option is a no-op and should have been removed long ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we expose
IndexFieldDataServiceoutside of IndexService to do maintainanceor lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData
via
QueryShardContextthat should encapsulate all access to it. This also ensures that we controlall other functionality like cache clearing etc.
This change also removes the
recycleroption fromClearIndicesCacheRequestthis option is a no-op and should have been removed long ago.