-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Move more token filters to analysis-common module #25784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more token filters to analysis-common module #25784
Conversation
jpountz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a commet about how to handle GetTermVectorsIT, otherwise it looks good. Maybe @nik9000 has an idea how to handle such tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how hard would it be to keep this test in core by plugging in a mochk payload filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all depends on if you are testing the term vectors API (stay in core with a mock) or if you are testing something super specific to this token filter. If it is specific, then I'd move it over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ESIntegTestCase subclasses to end in either Tests or IT when they are outside of core but since they don't need the Elasticsearch I like to name them like Tests instead of IT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try move this test back to core and use a mock payload filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was trying to keep them in alphabetical order.... No big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-arranged the lines in alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all depends on if you are testing the term vectors API (stay in core with a mock) or if you are testing something super specific to this token filter. If it is specific, then I'd move it over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ESIntegTestCase subclasses to end in either Tests or IT when they are outside of core but since they don't need the Elasticsearch I like to name them like Tests instead of IT.
db8e9bf to
ecc1481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer
else {
return false;
}
Just a bit more balanced looking. No big deal either way I guess.
The following token filters were moved: delimited_payload_filter, keep, keep_types, classic, apostrophe, decimal_digit, fingerprint, min_hash and scandinavian_folding. Relates to elastic#23658
625106b to
0b776a1
Compare
The following token filters were moved: delimited_payload_filter, keep, keep_types, classic, apostrophe, decimal_digit, fingerprint, min_hash and scandinavian_folding.
Relates to #23658